-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add env for arm64 and xfail geospatial tests #8371
Conversation
138a6f5
to
a119133
Compare
Add environment-arm64.yml to build dev env on mac m1 and m2. While doing this, a shapely/geos bug fix was exposed (see shapely issue 1992). Including the corresponding fixes, when shapely is upgraded, the xfails should start xpass.
a119133
to
71efbf4
Compare
I should take care of this one #8375 here too. Not sure what's the best way. Maybe pinning dask? edit: maybe add to |
With this environment, I tried
and pretty much everything fails with
for the record I do have installed cc: @chloeh13q @deepyaman any idea what's happening here? EDIT: turns out I don't have java install (why would I 😛) . I'm trying to brew install and it goes through but it's asking me to do some things, but I don't know what's the prefer/recommended option here. I did
|
@ncclementi I use sdkman to manage java because I have multiple versions of java running on my computer. Installing java 11 using sdkman is pretty straightforward, you just need to run sdk install java 11.0.19-tem and there is no extra step involved. I don't remember having to symlink when I installed java11 via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, otherwise LGTM.
Thanks for powering through this 😬
FWIW |
Co-authored-by: Phillip Cloud <[email protected]>
Add environment-arm64.yml to build dev env on mac m1 and m2.
While doing this, a shapely/geos bug fix was exposed (see issue shapely/shapely#1992). Including the corresponding fixes, when shapely is upgraded, the xfails should start xpass.
This PR: needs a follow up for documentation. To point out:
apache-flink
install will downgrade some packages.go-shfmt
the pacakge is not available for amr64 and it's not on pip. I don't see this package on our currentrequirement-dev.txt
so I'll ignore this.quarto >=1.4
is not available inconda-forge
it'll have to be installed following https://quarto.org/docs/get-started/index.html